Add extensible metadata into Setup #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def equiv(a: Array[T2[String, String]], b: Array[T2[String, String]]): Boolean = | ||
| ((a.toList filter { x => !(x.get1 startsWith "info.") }) sameElements | ||
| (b.toList filter { x => !(x.get1 startsWith "info.") })) | ||
| } |
There was a problem hiding this comment.
Two extras are considered equivalent if they have the same mapping for all keys that do not start with info.?
So the two following extras are equivalent?
val e1 = Array(("info.foo", "foo"))
val e2 = Array(("info.foo", "bar"), ("info.baz", "hello"))Why?
There was a problem hiding this comment.
When the metadata is not equivalent we will invalidate the previous compilation result, but there might be a situation where we would like to track some information without invalidating the previous.
|
LGTM |
eed3si9n
added a commit
that referenced
this pull request
Dec 22, 2015
Add extensible metadata into Setup
dwijnand
pushed a commit
to dwijnand/zinc
that referenced
this pull request
Jun 26, 2017
Run scripted tests in the alphabetical order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup now contains an array of
(String, String):{ "name": "extra", "type": "xsbti.T2<String, String>*" }This can be used to invalidate previous analysis for various purposes including sbt version changes.
/review @Duhemm, @dwijnand