Port scripted tests from sbt/sbt #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this duplicating code with the sbt repo? |
|
@dwijnand Yes. The core scripted engine is currently duplicated. I can split it out into util. |
|
If deduping into util is feasable, I think it would be preferable. Thanks. |
|
I suggest we merge this as is and open an issue with a few points:
I see there are tests that are marked pending because they depend on a structure with subprojects or because they use compiler plugins. I guess these tests will be ported to sbt/sbt 1.0's build? LGTM |
|
Yea. Let's do that so you can work on them. |
eed3si9n
added a commit
that referenced
this pull request
Dec 22, 2015
Port scripted tests from sbt/sbt
dwijnand
pushed a commit
to dwijnand/zinc
that referenced
this pull request
Jun 26, 2017
Scripted logger logs everything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't cover all capability of
build.sbtand flexibility, but it can do basic compile and file copying type of tests./review @Duhemm, @dwijnand