Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of sbt/sbt#363 I am unable to say anything about the perf characteristics of this PR.
I guess it is addressing the same problem that #371 is addressing and a hacky alternative to #433 (which is probably the correct solution).
What I thought was an I/O bottleneck in sbt/io#79 turned out to be a CPU hashcode bottleneck when hashing classpath files, not source files. YourKit doesn't pick up the hash/crypto work, showing it as InputFilterStream. Given the many many bugs in the entire scala tooling chain when it comes to
.jar
files mutating on disk, see https://gitlab.com/fommil/class-monkey/blob/master/README.md, I really don't think SHA-1 is needed here. Timestamps (and file size) should be more than enough.Also, this hashing could be done in parallel. Even if it's as simple as using the terrible
.par
.