FPORT: Consider signatures of methods before and after erasure in ExtractAPI #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signatures of methods that have value classes as arguments or return type change during the erasure phase. Because we only registered signatures before the erasure, we missed some API changes when a class was changed to a value class (or a value class changed to a class). This commit fixes this problem by recording the signatures of method before and after erasure. Fixes sbt/sbt#1171
|
This makes no sense. Removing |
|
👍 Travis passed. |
7 tasks
Duhemm
added a commit
that referenced
this pull request
Jan 21, 2016
It depends on improved support for value classes in the incremental compiler (see sbt/sbt#2261 and #54).
|
Note: We need to re-enable scripted test |
eed3si9n
added a commit
that referenced
this pull request
Jan 21, 2016
…before-and-after-erasure-in-extractapi FPORT: Consider signatures of methods before and after erasure in ExtractAPI
eed3si9n
deleted the
fport/consider-signatures-of-methods-before-and-after-erasure-in-extractapi
branch
|
Merged |
Duhemm
added a commit
that referenced
this pull request
Jan 21, 2016
It depends on improved support for value classes in the incremental compiler (see sbt/sbt#2261 and #54).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port of sbt/sbt#2261.
(Supersedes #51, thanks @dwijnand!)