Avoid slow path for associated file more often #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retronym
force-pushed
the
topic/assoc-file
branch
from
466bc8c
to
793c040
Compare
dwijnand
reviewed
Apr 22, 2020
dwijnand
reviewed
Apr 23, 2020
dwijnand
reviewed
Apr 23, 2020
retronym
force-pushed
the
topic/assoc-file
branch
from
8526c29
to
3c4e453
Compare
Also fix a bug in fullName with encoded names.
retronym
force-pushed
the
topic/assoc-file
branch
from
3c4e453
to
b645682
Compare
Duhemm
added a commit
to Duhemm/incrementalcompiler
that referenced
this pull request
Nov 27, 2020
Previously, we would complete symbols before trying to find the associated classfile. This is problematic for symbols where we don't have the classfile (for instance, when compiling with Pants' `strict_deps` enabled). This initialization was introduced in sbt#758, to workaround a scalac bug where the associated classfile of a symbol wouldn't be set before the symbol is completed. This bug has been fixed in Scala 2.12.12 and later (see scala/scalac#8889). Fixes sbt#949
eed3si9n
pushed a commit
to eed3si9n/zinc
that referenced
this pull request
Nov 30, 2020
Previously, we would complete symbols before trying to find the associated classfile. This is problematic for symbols where we don't have the classfile (for instance, when compiling with Pants' `strict_deps` enabled). This initialization was introduced in sbt#758, to workaround a scalac bug where the associated classfile of a symbol wouldn't be set before the symbol is completed. This bug has been fixed in Scala 2.12.12 and later (see scala/scalac#8889). Fixes sbt#949
Duhemm
added a commit
to scalacenter/zinc
that referenced
this pull request
Nov 30, 2020
Previously, we would complete symbols before trying to find the associated classfile. This is problematic for symbols where we don't have the classfile (for instance, when compiling with Pants' `strict_deps` enabled). This initialization was introduced in sbt#758, to workaround a scalac bug where the associated classfile of a symbol wouldn't be set before the symbol is completed. This bug has been fixed in Scala 2.12.12 and later (see scala/scalac#8889). See sbt#949 Port of sbt#950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix a bug in fullName with encoded names.
Fixes #757