-
Notifications
You must be signed in to change notification settings - Fork 20
I18n for Page factory #20
Conversation
successfully tested on mobile-inside branch |
@@ -1,52 +1,43 @@ | |||
package ru.sbtqa.tag.pagefactory; | |||
|
|||
import static java.lang.String.format; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, undone import changes in all of the files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -734,7 +696,7 @@ public String getTitle() { | |||
|
|||
/** | |||
* Search for the given WebElement in page repository storage, that is being generated during preconditions to all | |||
* tests. If element is found, return its title annotation. If nothing found, log debug message and return | |||
* tests. If element is found, return its title annotation. If nothing found, LOG debug message and return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you do refactor on 'log'-variable or stupid-ctrl-h?
@@ -1157,7 +1128,7 @@ private static String getFieldTitle(Field field) { | |||
|
|||
/** | |||
* Get title annotation of specified WebElement, and add it as a parameter to allure report results, | |||
* with corresponding value. If there is no title annotation, log warning and exit | |||
* with corresponding value. If there is no title annotation, LOG warning and exit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary rename to upper case again
generalize LOG constant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imports ordering is a bullshit. I'll create issue about synchronizing codestyle between netbeans and idea
Guys! Its major feature. Please lookup ang give feedback.