This repository has been archived by the owner on Nov 15, 2020. It is now read-only.
I18n for Page factory #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clicman
requested review from
0I0u3uk,
kosteman,
warorc,
ScorpDS,
iamanikeev,
iRSV,
voronsp and
SandraBarmina
|
successfully tested on mobile-inside branch |
kosteman
suggested changes
Feb 9, 2017
| @@ -1,52 +1,43 @@ | |||
| package ru.sbtqa.tag.pagefactory; | |||
|
|
|||
| import static java.lang.String.format; | |||
There was a problem hiding this comment.
please, undone import changes in all of the files
| @@ -734,7 +696,7 @@ public String getTitle() { | |||
|
|
|||
| /** | |||
| * Search for the given WebElement in page repository storage, that is being generated during preconditions to all | |||
| * tests. If element is found, return its title annotation. If nothing found, log debug message and return | |||
| * tests. If element is found, return its title annotation. If nothing found, LOG debug message and return | |||
There was a problem hiding this comment.
did you do refactor on 'log'-variable or stupid-ctrl-h?
| @@ -1157,7 +1128,7 @@ private static String getFieldTitle(Field field) { | |||
|
|
|||
| /** | |||
| * Get title annotation of specified WebElement, and add it as a parameter to allure report results, | |||
| * with corresponding value. If there is no title annotation, log warning and exit | |||
| * with corresponding value. If there is no title annotation, LOG warning and exit | |||
There was a problem hiding this comment.
unnecessary rename to upper case again
generalize LOG constant
voronsp
approved these changes
Feb 10, 2017
warorc
approved these changes
Feb 10, 2017
ScorpDS
approved these changes
Feb 10, 2017
kosteman
approved these changes
Feb 10, 2017
This was referenced Feb 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guys! Its major feature. Please lookup ang give feedback.