Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing subsection identifiers to lookup_by_ilcs() #3

Closed
ghing opened this issue Jul 30, 2014 · 3 comments
Closed

Allow passing subsection identifiers to lookup_by_ilcs() #3

ghing opened this issue Jul 30, 2014 · 3 comments
Assignees
@bepetersn
Labels
enhancement in progress

Comments

@ghing
Copy link
Contributor

ghing commented Jul 30, 2014

No description provided.

ghing added a commit that referenced this issue Jul 30, 2014
@ghing
Update tests to reflect passing subsection parts
269be4e 
Update the tests for lookup_by_ilcs() to try to lookup elements
by subsection bits.

Also change the signature of lookup_by_ilcs to allow [arbitrary
argument
lists](https://docs.python.org/2/tutorial/controlflow.html#arbitrary-argument-lists) to be able to pass in the subsection parts of the ILCS reference.

These tests won't pass but are there as an example for @bepetersn
to continue this work.

Addresses #3
@ghing
Copy link
Contributor Author

ghing commented Jul 30, 2014

@bepetersn, I pushed the first couple of tests that we wrote in the Hangout today to the handle_subsections branch. You should make a local copy of that branch and push changes to that remote branch. Happy hacking!

@ghing
Copy link
Contributor Author

ghing commented Aug 1, 2014

@bepetersn, where are you with this?

@bepetersn bepetersn mentioned this issue Aug 1, 2014
Closed
@ghing ghing closed this as completed in b6ebf40 Aug 2, 2014
@ghing
Copy link
Contributor Author

ghing commented Aug 2, 2014

@bepetersn Nice work on this. The recursive approach is clever. I've merged the pull request and deleted the handle_subsections branch.

@ghing ghing mentioned this issue Aug 2, 2014
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bepetersn bepetersn

Labels
enhancement in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ghing @bepetersn