-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: onchainkit initial commit #11
Conversation
Ohh while testing scaffold-eth/create-eth#74 I was getting when I navigate to /onchainkit-examples : And also theme behaves in different way : |
Updated version, now it should work. It's because of
I didn't know when that when merging
It's because of
Removed when testing don't forget to get onchainkit API key (see readme) Thanks! |
Thanks Rinat! Also noticed that when you do |
Updated scaffold-eth/create-eth#74 and this pr. Everything seems work and no errors during |
extension/packages/nextjs/components/OnchainKitScaffoldProvider.tsx
Outdated
Show resolved
Hide resolved
Thanks @rin-st!! Seems to work great! Will try to test / review tomorrow, Also I am not sure whats the best way to handle this but at some places our SE-2 colors are changed for example : Notice it has changed it color to violet when you hover over the Switch Icon |
Updated Example page since they changed they documentation structure and previous links were outdated already. a9770b6
Yes, I mentioned it in the first message.
I believe it should be fixed on their side, since they define their color names like But for now, I used their colors since it's onchainkit extension 🙂 , and without it their styles will be broken |
Created an issue coinbase/onchainkit#852 |
extension/packages/nextjs/components/ScaffoldEthAppWithProviders.tsx.args.mjs
Outdated
Show resolved
Hide resolved
It is fixed in onchainkit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tysm @rin-st, this is really nice! and works great!
Thanks all!! <3 Let's create a PR to main adding this extension + a PR in create-eth to "publish" the curated extension. |
Oh, forgot about it
It's already added https://github.com/scaffold-eth/create-eth/pull/74/files#diff-7025c91537448e2ff14397d6f1455b06e2e6da125f21beeb860a474a003a65a2R16 |
Adds support of OnchainKIt
Adds page with OnchainKit components
Fixes #8
Notes:
See Readme for networks support
Our react-query, viem and wagmi versions should be very close or even the same as in OnchainKit, or multiple error occurs. Not sure how to make it up to date all the time
Tailwind integrations requires to define theme variables, and some of them overwrite ours (works for other projects with tailwind)
To test
TODO:
create-eth
first: Possibility to change files required for onchainkit extension create-eth#74