Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a working initial viewer that shows the Venetus A scholia and text, with regions of interest #100

Closed
gregorycrane opened this issue Dec 8, 2022 · 21 comments
Assignees

Comments

@gregorycrane
Copy link

https://www.homermultitext.org/facsimiles/venetus-a-2020/pages/urn_cite2_hmt_msA-v1_248v.html -- this is not using IIIF and is a one-off, but it nicely shows the information.

@gregorycrane
Copy link
Author

image

@jacobwegner
Copy link
Contributor

@gregorycrane: Thanks for sharing.

https://www.homermultitext.org/facsimiles/venetus-a-2020/pages/urn_cite2_hmt_msA-v1_12r.html would correspond our view at https://beyond-translation.perseus.org/reader/urn:cts:greekLit:tlg0012.tlg001.msA-folios:12r.1.1-12r.1.25?mode=folio.

@pletcher and I just had a call walking through some of the building blocks within Beyond Translation (specifically the backend where we're loading in some of the CITE data from the CEX files and how we're querying that data for display on the frontend).

To start with, he's going to explore being able to select a text part reference in the viewer and to see the bounding box drawn within OpenSeadragon; there are a few more things we'll need to get sorted out with the scholia data to integrate the regions of interest with the scholia that we'll take on in a later pass.

@jacobwegner
Copy link
Contributor

jacobwegner commented Jan 19, 2023

@pletcher and @gregorycrane: I had a meeting last week with Cliff Anderson (who works at Jean and Alexander Heard Library at Vanderbilt University), and he was demonstrating some ROI / IIIF functionality that Wikimedia Commons and Wikidata expose.

The Wikidata page for coronation of Napoleon I refers to a painting (Jacques-Louis David, The Coronation of Napoleon) that has been tagged with ROIs for the people in the painting.

https://wd-image-positions.toolforge.org/iiif_region/pct:52.6,55,13.4,33.3 has a viewer that draws the ROIs, and the ROIs then link to Wikidata pages (e.g. Napoleon).

I'm not suggesting we incorporate Wikidata or their viewer, but just thought it was another example of interactivity between the image and structured content.

@jacobwegner
Copy link
Contributor

PR open at:

scaife-viewer/frontend#65

@jacobwegner
Copy link
Contributor

jacobwegner commented Feb 17, 2023

@pletcher and I just talked through the next round of things on a call:

  • @jacobwegner to finish the PR reviews
  • @jacobwegner to ingest the ~20 scholia annotations into the backend so that they are queryable using the ImageROI GraphQL field (via Integrate urn:cite2:hmt:va_dse.v1:schol* to passage tokens #112)
  • @jacobwegner to leave a few "breadcrumbs" for @pletcher on token-level highlighting in scaife-viewer/frontend
    • the idea that in a "display mode", we "highlight" in yellow tokens that have rich data available
    • when a user makes a selection on a token, the selected token highlight changes to "green"
    • a user can click on the active selection to de-select it
  • @pletcher will take a pass at allowing a user to select the "form" in the main reader and then highlight the scholia in the folio viewer using the ROI data

If / when all that is working, we can experiment more with bi-directional selection (click a scholia entry to highlight the form), and then other thorny issues (distinguishing between "line" selections and "form" selections, etc)

@jacobwegner
Copy link
Contributor

(@jacobwegner would like to also revisit the "commentaries" widget / display mode for scholia...so that selecting a form or scholia entry on the folio viewer would interact with the sidebar widget

@pletcher
Copy link
Collaborator

Hi @jacobwegner, sorry for taking so long to get back to this. I'm working on the scholia highlights, and I noticed that textAnnotation ROI fields are available at the hosted GraphQL instance, but I can't seem to find the commit where that change happened to test it locally.

I just get an empty array in the roi field that I added to ScholiaWidget's gql query.

Do I need to re-ingest some data, or should I be working off of a different branch?

Thanks!

@jacobwegner
Copy link
Contributor

(@jacobwegner and @pletcher to sync up on the closed PR; bring new styles forward)

@jacobwegner
Copy link
Contributor

@pletcher Would you mind linking to whatever branches your latest is on into this issue, and I can resurrect the PRs / preview instance?

I can then also look at the data mapping task and circle back to you.

Thanks!

@pletcher
Copy link
Collaborator

pletcher commented Jun 13, 2023

Hi @jacobwegner, sure thing, and sorry for the delay!

scaife-viewer/frontend: https://github.com/pletcher/scaife-viewer-frontend/tree/feature/regions-of-interest

scaife-viewer/backend: https://github.com/pletcher/scaife-viewer-backend/tree/feature/regions-of-interest

I think that should be everything.

Thanks!

@jacobwegner
Copy link
Contributor

jacobwegner commented Oct 24, 2023

Getting very close to these changes being merged.

A few final TODOS:

image (this is already happening on prod, so we could skiip)

@jacobwegner
Copy link
Contributor

@gregorycrane latest data and code have been deployed here:

https://beyond-transl-pr-111.herokuapp.com/reader/urn:cts:greekLit:tlg0012.tlg001.msA-folios:12r.1.1-12r.1.25?mode=folio

image image image image

I still have a couple of small housekeeping tasks, but I think at this point I'd like you to take a look and see if what we have done is "good enough".

@jacobwegner
Copy link
Contributor

@jacobwegner
Copy link
Contributor

jacobwegner commented Oct 31, 2023

Last bits of feedback from @gregorycrane:

  • Adding labels / colors to the different kinds of scholia
  • Investigate "bounds" checking for OpenSeaDragon zooming (full-screen behavior within the "split-pane" viewer)
  • Move future improvements to a v2 issue (e.g., scroll into view, filtering by scholia kind, etc --> Scholia / ROI improvements, v3 #177)

@jacobwegner
Copy link
Contributor

Have to step away for the day, but I did find a few OpenSeaDragon settings to fix the zoom issues, and I've been able to replicate some of the border styling from HMT:

Scaife Viewer:

image

HMT:

image

@jacobwegner
Copy link
Contributor

Scholia entries in the sidebar now show the same colors as the viewer:

image

and we have a legend that shows what type of scholia correspond to each color:

image

@jacobwegner
Copy link
Contributor

@gregorycrane I have made all of the changes we discussed on Tuesday. I'm going to move on to UD stuff next week, but I am still waiting a final look from you before we merge / deploy to production:

https://beyond-transl-pr-111.herokuapp.com/reader/urn:cts:greekLit:tlg0012.tlg001.msA-folios:12r.1.1-12r.1.25?mode=folio

image

@jacobwegner
Copy link
Contributor

@gregorycrane The latest changes to the Legend and showing Scholia kind on hover have been deployed to the preview instance:

https://beyond-transl-pr-111.herokuapp.com/reader/urn:cts:greekLit:tlg0012.tlg001.msA-folios:12r.1.1-12r.1.25?mode=folio

image

I'm going to cut a production release and will close this issue when that has been completed.

@jacobwegner
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Accepted / Completed
Development

No branches or pull requests

3 participants