Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing macroparadise's inclusion as a compiler plugin #56

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Fixing macroparadise's inclusion as a compiler plugin #56

merged 1 commit into from
Apr 7, 2017

Conversation

dominv
Copy link
Contributor

@dominv dominv commented Apr 7, 2017

This PR resolves #55 and fixes the macroparadise's inclusion as a compiler plugin including it only when the .jar is present.

@juanpedromoreno could you please review?

Thanks!

@raulraja raulraja temporarily deployed to scala-evaluator-pr-56 April 7, 2017 06:07 Inactive
juanpedromoreno
juanpedromoreno approved these changes Apr 7, 2017
View reviewed changes
Copy link
Contributor

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@juanpedromoreno juanpedromoreno merged commit db798de into master Apr 7, 2017
@juanpedromoreno juanpedromoreno deleted the dv-55-bug-fix-macroparadise-compiler-plugin branch April 7, 2017 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix macroparadise's inclusion as a compiler plugin
3 participants
@dominv @juanpedromoreno @raulraja