Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicits Chapter: Edits to docstrings, plus one code change #45

Merged
merged 1 commit into from
Jul 18, 2016
Merged

Implicits Chapter: Edits to docstrings, plus one code change #45

merged 1 commit into from
Jul 18, 2016

Conversation

jonboiser
Copy link
Contributor

@jonboiser jonboiser commented Jul 17, 2016

  1. Fix markdown list at line 11
  2. Add code backticks to some terms
  3. Some edits (colons and capitalizing Implicit Function Parameters) for consistency w/ rest of doc
  4. On line 105
-def asDefaultImplicits(res0: Float) {
+def asDefaultImplicits(res0: BigDecimal) {

Since, I had to manually cast the answer on the koan to Float. IDK if this requires a change on somewhere else in the code, but can do it if you point me to the file.

@ghost
Copy link

ghost commented Jul 18, 2016

Great improvements, thanks a lot! The test code for the modified exercise can be found here.

@jonboiser
Copy link
Contributor Author

@dialelo I think the fix was pretty simple. Even removed a line of what looked like dead code. Could you review?

@raulraja
Copy link
Member

@jonboiser Looks great. Thanks for your contribution!

@raulraja raulraja merged commit 6ca990f into scala-exercises:master Jul 18, 2016
@jonboiser jonboiser deleted the patch-1 branch July 19, 2016 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants