-
Notifications
You must be signed in to change notification settings - Fork 47
Adapt test to proposed change in classOf typechecking #96
Conversation
In response to: https://scala-ci.typesafe.com/job/scala-2.11.x-integrate-ide/1523/console
Encountered scala/scala#4725 |
bc8016a
to
9e694c8
Compare
java.io.IOException | ||
scala.this.Predef.String | ||
""" | ||
val deps2 = deps1 + "\n" + scala.this.Predef.classOf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why didn't you just add this dependency to the previous list of dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to structure the test so it works before and after the commit in the
compiler.
On Thu, 10 Sep 2015 at 7:40 pm Simon Schäfer notifications@github.com
wrote:
In
src/test/scala/scala/tools/refactoring/tests/analysis/CompilationUnitDependenciesTest.scala
#96 (comment)
:@@ -792,7 +788,26 @@ class CompilationUnitDependenciesTest extends TestHelper with CompilationUnitDep
@throws(classOf[IOException])
def read() = in.read()
}
- """)
- """
- val deps1 = """java.io.BufferedReader
java.io.FileReader
java.io.IOException
scala.this.Predef.String
"""
- val deps2 = deps1 + "\n" + scala.this.Predef.classOf
Why didn't you just add this dependency to the previous list of
dependencies?—
Reply to this email directly or view it on GitHub
https://github.com/scala-ide/scala-refactoring/pull/96/files#r39141571.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh ok, you are right. There was only a compilation error because the scala.this.Predef.classOf
is not part of the string literal.
9e694c8
to
1596b44
Compare
The irony of authoring IDE patches in Sublime without locally compiling... |
02356ff
to
46832f8
Compare
46832f8
to
946c3e8
Compare
Refer to this link for build results (access rights to CI server needed): https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-scala-refactoring-validator/110/ |
LGTM |
Adapt test to proposed change in classOf typechecking
No description provided.