Skip to content
This repository has been archived by the owner on Sep 3, 2020. It is now read-only.

Adapt test to proposed change in classOf typechecking #96

Merged
merged 1 commit into from
Sep 10, 2015

Conversation

retronym
Copy link
Contributor

No description provided.

@retronym
Copy link
Contributor Author

In response to:

https://scala-ci.typesafe.com/job/scala-2.11.x-integrate-ide/1523/console


Results :

Failed tests: 
  CompilationUnitDependenciesTest.ClassInAnnotationDeps:780->assertDependencies:36->assertTrees:29 expected:<...a.this.Predef.String[]> but was:<...a.this.Predef.String[
scala.this.Predef.classOf]>

Encountered scala/scala#4725

Review by @misto or @sschaef

java.io.IOException
scala.this.Predef.String
"""
val deps2 = deps1 + "\n" + scala.this.Predef.classOf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't you just add this dependency to the previous list of dependencies?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to structure the test so it works before and after the commit in the
compiler.
On Thu, 10 Sep 2015 at 7:40 pm Simon Schäfer notifications@github.com
wrote:

In
src/test/scala/scala/tools/refactoring/tests/analysis/CompilationUnitDependenciesTest.scala
#96 (comment)
:

@@ -792,7 +788,26 @@ class CompilationUnitDependenciesTest extends TestHelper with CompilationUnitDep
@throws(classOf[IOException])
def read() = in.read()
}

  • """)
  • """
  • val deps1 = """java.io.BufferedReader
  •     java.io.FileReader
    
  •     java.io.IOException
    
  •     scala.this.Predef.String
    
  •     """
    
  • val deps2 = deps1 + "\n" + scala.this.Predef.classOf

Why didn't you just add this dependency to the previous list of
dependencies?


Reply to this email directly or view it on GitHub
https://github.com/scala-ide/scala-refactoring/pull/96/files#r39141571.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ok, you are right. There was only a compilation error because the scala.this.Predef.classOf is not part of the string literal.

@retronym
Copy link
Contributor Author

The irony of authoring IDE patches in Sublime without locally compiling...

@retronym retronym force-pushed the topic/classOf branch 2 times, most recently from 02356ff to 46832f8 Compare September 10, 2015 10:31
@kiritsuku
Copy link
Member

LGTM

kiritsuku added a commit that referenced this pull request Sep 10, 2015
Adapt test to proposed change in classOf typechecking
@kiritsuku kiritsuku merged commit eae83db into scala-ide:master Sep 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants