Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing whitespace from non-Scaladoc comments. #150

Merged
merged 2 commits into from
Feb 19, 2016

Conversation

jkinkead
Copy link
Collaborator

Fixes #149 .

Note unit tests which will fail on master.

@@ -99,6 +99,44 @@ class CommentFormatterTest extends AbstractFormatterTest {
| */
|"""

"""/**
| * Trailing whitespace on this line and the line below should be stripped.
| *
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to have trailing whitespace in our code. Please append a $ sign at the end (or some other character) and strip it away afterwards with str.replace("$", "")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkinkead
Copy link
Collaborator Author

Replaced EOL space literals with unicode escapes.

@kiritsuku
Copy link
Member

LGTM

@ghprb-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins.scala-ide.org:8496/jenkins//job/ghprb-scalariform/22/
Test PASSed.

kiritsuku added a commit that referenced this pull request Feb 19, 2016
Remove trailing whitespace from non-Scaladoc comments.
@kiritsuku kiritsuku merged commit 401b4a9 into scala-ide:master Feb 19, 2016
@jkinkead jkinkead deleted the trailing_whitespace branch March 2, 2016 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants