Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to add newlines to the end of files. #191

Merged
merged 2 commits into from
Feb 19, 2016

Conversation

jkinkead
Copy link
Collaborator

Fixes #113 .

@ghprb-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins.scala-ide.org:8496/jenkins//job/ghprb-scalariform-sbt/13/

override val debug = false

{
implicit val formattingPreferences = FormattingPreferences.setPreference(NewlineAtEndOfFile, true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests should be repeated for the false case.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I had to rename them due to how the test cases are generated - they need different text, else they end up with the same name & cause errors while running.

@ghprb-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins.scala-ide.org:8496/jenkins//job/ghprb-scalariform/18/
Test PASSed.

@kiritsuku
Copy link
Member

LGTM

kiritsuku added a commit that referenced this pull request Feb 19, 2016
Add an option to add newlines to the end of files.
@kiritsuku kiritsuku merged commit 2e8039e into scala-ide:master Feb 19, 2016
@jkinkead jkinkead deleted the eol_at_eof branch March 2, 2016 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants