Update dom/form data #800
Update dom/form data #800
Conversation
Add MDN documentation strings for FormData
| * The field's value. This can be a string or `Blob` (including subclasses such as File). If none of these are | ||
| * specified the value is converted to a string. | ||
| */ | ||
| def append(name: js.Any, value: String): Unit = js.native |
There was a problem hiding this comment.
Why is name: js.Any, isn't only String allowed here?
There was a problem hiding this comment.
Oh, the problem was caused by not fixing the original append method properly.
name must be a string. I just updated it, thank you !
|
|
||
| /** XMLHttpRequest Level 2 adds support for the new FormData interface. FormData objects provide a way to easily | ||
| * construct a set of key/value pairs representing form fields and their values, which can then be easily sent using | ||
| * the XMLHttpRequest send() method. | ||
| */ | ||
| @js.native | ||
| @JSGlobal | ||
| class FormData(form: HTMLFormElement = js.native) extends js.Object { | ||
| class FormData(form: HTMLFormElement = js.native) extends js.Iterable[js.Tuple2[String, String]] { |
There was a problem hiding this comment.
| class FormData(form: HTMLFormElement = js.native) extends js.Iterable[js.Tuple2[String, String]] { | |
| class FormData(form: HTMLFormElement = js.native) extends js.Iterable[js.Tuple2[String, String | Blob]] { |
|
|
||
| /** XMLHttpRequest Level 2 adds support for the new FormData interface. FormData objects provide a way to easily | ||
| * construct a set of key/value pairs representing form fields and their values, which can then be easily sent using | ||
| * the XMLHttpRequest send() method. | ||
| */ | ||
| @js.native | ||
| @JSGlobal | ||
| class FormData(form: HTMLFormElement = js.native) extends js.Object { | ||
| class FormData(form: HTMLFormElement = js.native) extends js.Iterable[js.Tuple2[String, String]] { |
There was a problem hiding this comment.
Also, it seems there are three possible constructors.
new FormData()
new FormData(form)
new FormData(form, submitter)class FormData extends ... {
def this(form: HTMLFormElement) = this()
def this(form: HTMLFormElement, submitter: HTMLElement) = this()
}There was a problem hiding this comment.
class FormData(form: HTMLFormElement = js.native) extends ... {
def this(form: HTMLFormElement) = this(form)
def this(form: HTMLFormElement, submitter: HTMLElement) = this(form)
}I think this is good point !
I've looked at other api codes using this() and i make this code,
but I'm not sure if this change is correct.
I'd be grateful if someone could fix this part for sure
There was a problem hiding this comment.
I've looked at other api codes using
this()and i make this code,
That won't work, because there are two constructors that take a form. How wil it know which one to use?
I believe the correct change is the one I suggested in #800 (comment).
There was a problem hiding this comment.
got it !
I will add this part :)
related issue #798