Build architecture specific setjmp .S code more efficiently, reduce liklihood of Gnu ld error #3926
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A better and stronger way to fix #3916
Consolidate the four architecture specific setjmp .S files into one. That means that the single file
presented to the compiler will always contain meaningful code (or an unsupported OS). This
does away with 'throw-away' compilations and empty .o files which take up hundreds of bytes.
Ensure that the new
setjmp.S
file has a guarded section at the end to ensure that the compileralways generates a
.note.GNU-stack
section when using a Linux compiler with ELF output .I did_not check the various "unwind.S" files because I have never seen ld.bfd complain
about them. They may be an issue there.