Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.13.14 draft release notes #869

Closed
wants to merge 3 commits into from

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Apr 19, 2024

@SethTisue SethTisue mentioned this pull request Apr 19, 2024
92 tasks
releases/2.13.14.md Outdated Show resolved Hide resolved
@sjrd
Copy link
Member

sjrd commented Apr 23, 2024

It might be worth mentioning that the 5 fake source files of library-aux are now part of the sources jar. It can impact tools that use the source jar in a meaningful way. For example the Scala.js build needs to explicitly exclude those files using

scalalibInternal.v2_13/Compile/sources ~= {
  val excludes = Set("Any.scala", "AnyRef.scala", "Nothing.scala", "Null.scala", "Singleton.scala")
  prev => prev.filterNot(f => f.getParentFile.getName == "scala" && excludes.contains(f.getName))
}

I wonder if IDEs will actually be able to deal with those or if they will panic. Have we checked with IntelliJ and Metals?

@lrytz
Copy link
Member

lrytz commented Apr 23, 2024

IntelliJ was tested (scala/scala#10714), including the sources was actually a request that came through IntelliJ (https://youtrack.jetbrains.com/issue/SCL-22167).

For metals I tried a small sbt project with

resolvers += "scala-integration" at "https://scala-ci.typesafe.com/artifactory/scala-integration/"
ThisBuild / scalaVersion := "2.13.14-bin-a527019"

While I can navigate to Unit for example
image

I cannot navigate to the new sources like AnyRef / Null.

@tgodzik is that worth a ticket?

@tgodzik
Copy link

tgodzik commented Apr 23, 2024

We might need to first release metals for that versions, which requires semanticdb. We can confirm once everything is out.

@SethTisue
Copy link
Member Author

If anyone is trying out -Xsource-features, be sure and look at the doc revisions at scala/docs.scala-lang#2994 — the PR will be merged at announcement time.

@SethTisue
Copy link
Member Author

@SethTisue SethTisue closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants