Skip to content
This repository has been archived by the owner on Sep 8, 2022. It is now read-only.

reverse sense of diffs (with --show-diff and --verbose) #80

Closed
SethTisue opened this issue Apr 6, 2017 · 1 comment
Closed

reverse sense of diffs (with --show-diff and --verbose) #80

SethTisue opened this issue Apr 6, 2017 · 1 comment

Comments

@SethTisue
Copy link
Member

the + vs - direction is the reverse of what you would expect

@som-snytt
Copy link
Contributor

som-snytt commented Apr 6, 2017

#81

Was git vs difflib:

# starting 1 test in neg
!! 1 - neg/t8300-overloading.scala               [output differs]
% diff /home/apm/projects/scala/test/files/neg/t8300-overloading-neg.log /home/apm/projects/scala/test/files/neg/t8300-overloading.check
@@ -1,5 +1,5 @@
 t8300-overloading.scala:15: error: double definition:
-def foo(name: Test.u.Name): Nothing at line 14 and
+def goo(name: Test.u.Name): Nothing at line 14 and
 def foo(name: Test.u.TermName): Nothing at line 15
 have same type after erasure: (name: Universe#NameApi)Nothing
   def foo(name: TermName) = ???

# 0/1 passed, 1 failed in neg

# Failed test paths (this command will update checkfiles)
partest --update-check \
  /home/apm/projects/scala/test/files/neg/t8300-overloading.scala


# starting 1 test in neg
!! 1 - neg/t8300-overloading.scala               [output differs]
% diff /home/apm/projects/scala/test/files/neg/t8300-overloading-neg.log /home/apm/projects/scala/test/files/neg/t8300-overloading.checkdiff /home/apm/projects/scala/test/files/neg/t8300-overloading-neg.log /home/apm/projects/scala/test/files/neg/t8300-overloading.check
--- t8300-overloading.check
+++ t8300-overloading-neg.log
@@ -1,3 +1,3 @@
 t8300-overloading.scala:15: error: double definition:
-def goo(name: Test.u.Name): Nothing at line 14 and
+def foo(name: Test.u.Name): Nothing at line 14 and
 def foo(name: Test.u.TermName): Nothing at line 15
# 0/1 passed, 1 failed in neg

# Failed test paths (this command will update checkfiles)
partest --update-check \
  /home/apm/projects/scala/test/files/neg/t8300-overloading.scala

Now:

# starting 1 test in neg
!! 1 - neg/t8300-overloading.scala               [output differs]
% diff /home/apm/projects/scala/test/files/neg/t8300-overloading-neg.log /home/apm/projects/scala/test/files/neg/t8300-overloading.check--- t8300-overloading-neg.log
+++ t8300-overloading.check
@@ -1,3 +1,3 @@
 t8300-overloading.scala:15: error: double definition:
-def foo(name: Test.u.Name): Nothing at line 14 and
+def goo(name: Test.u.Name): Nothing at line 14 and
 def foo(name: Test.u.TermName): Nothing at line 15
# 0/1 passed, 1 failed in neg

# Failed test paths (this command will update checkfiles)
partest --update-check \
  /home/apm/projects/scala/test/files/neg/t8300-overloading.scala

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants