Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop XMLEventReader #293

Merged
merged 7 commits into from
Apr 18, 2019
Merged

Drop XMLEventReader #293

merged 7 commits into from
Apr 18, 2019

Conversation

ashawley
Copy link
Member

Follow-up to #193. Previously, #200.

@ashawley ashawley added this to the 2.0 milestone Apr 11, 2019
SethTisue
SethTisue approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in build.sbt, maybe it makes more sense to just set mimaPreviousVersion to None, now that we've moved to a 2.0 series and broken bincompat anyway?

@ashawley
Copy link
Member Author

ashawley commented Apr 18, 2019 •
edited
Loading

Yeah, the MiMa part of the build is going to get unwieldy, but I'd like to have MiMa enabled to track the changes.

@ashawley ashawley merged commit 37d437a into scala:master Apr 18, 2019
@ashawley ashawley deleted the drop-XMLEventReader branch April 18, 2019 15:25
@dwijnand dwijnand mentioned this pull request May 15, 2019
Closed
@ashawley ashawley removed this from the 2.0 milestone Jun 27, 2019
@SethTisue
Copy link
Member

here is a sample before-and-after for switching user code from scala.xml.pull to javax.xml.stream.events:
https://gist.github.com/SethTisue/2c84c855221bc5a31e129226ade2cb81

@SethTisue SethTisue mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethTisue SethTisue SethTisue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashawley @SethTisue