-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unspecialcase unicode escapes [WIP] #6661
Conversation
If CI is green, I'd like to request a community build to see what the fallout of such a change is, if any. |
Fixes scala/bug#3220 |
I would like to see community build for this PR, just to be sure, before I start polishing things up (right now there is a bunch of repeated code that needs cleaning up) But 2.13.x community build is AFAIK not really that far along. Is there an issue for that that I can watch? |
Why isn't the change just dependent on It's not obvious to me that the escape is great for interpolation. |
The 2.13 community build is currently not doing much because most projects don't compile yet for 2.13 (new collections, scala/community-build#710). You could however prepare a PR against 2.12.x with the change, then we can run the 2.12 community build. |
@som-snytt I knew |
@lrytz porting to 2.12 for a community build sounds like a good idea. A different dummy PR for that is probably going to be easier than re-targeting this PR, and then re-targeting it back. Does that strike you as a reasonable course of action? |
Yes! |
haphazard cherry-pick against 2.12.x This is a a re-target of scala#6661 against 2.12 with the intention of running a community build to see what the fallout is of such a change if any.
haphazard cherry-pick against 2.12.x This is a a re-target of scala#6661 against 2.12 with the intention of running a community build to see what the fallout is of such a change if any.
Unscheduling from M5 since this is WIP. |
@martijnhoekstra interested in carrying on with this...? |
@SethTisue yes, once we can get a sizable community build going for 2.13. Some things could break, and if I carry on with this, I'd need to have a robust migration story. Not sure whether this could realistically be targeted for a minor release, so this might have to go for 2.14 or 3 |
closing for inactivity, can be revived & reopened later. the 2.13 community build currently only has about ~60 (out of ~190) projects, it'll probably won't be much larger until around the time RC1 comes out |
I assume this will also resolve scala/bug#10873 |
I put scala/bug#3220 on the RC1 milestone, to help us not forget |
Explore removing the special status of unicode escapes.
In this PR, unicode escapes are treated like any other escape, except