Do not merge - unspecialcase unicode escapes #6709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should not be on the 2.12.7 milestone. In fact, this probably shouldn't be on a milestone at all - this is just abusing the PR system to validate and get a community build done. |
haphazard cherry-pick against 2.12.x This is a a re-target of scala#6661 against 2.12 with the intention of running a community build to see what the fallout is of such a change if any.
martijnhoekstra
force-pushed
the
uescape212
branch
from
c913a1e
to
c8f8b93
Compare
|
(ping me if I haven't gotten to this by the end of the week) |
|
@SethTisue This needs to pass CI first, and I'm both busy with work and with rubbing egg from my floating point face, so there is no rush |
|
okay, let's reopen once you're ready to run CI again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
haphazard cherry-pick against 2.12.x
This is a a re-target of #6661 against 2.12 with the intention
of running a community build to see what the fallout is
of such a change if any.