Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more fine grained check for scalacOptionsToRelax #262

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Nov 30, 2021

Creating this to start a conversation about it and to see if this would be alright as a follow-up to some of the work done in #196. If I understood the conversation right you want to avoid situations where this is set to error out causing issues. However, currently it strips out any usage of -Wconf. The situation that I'm in is that we want to avoid warnings from generated sources since we generate a ton of files with scalaxb that contains a whole bunch of compiler warnings. To silence these we use -Wconf:src=src_managed/.*:silent. This works great during normal compilation, but then when we run scalafix check in our CI our logs end up being full or warnings causing a scare. Would it be possible to make this more fine-grained like this to specifically target :e or :error?

@bjaglin
Copy link
Collaborator

bjaglin commented Nov 30, 2021

Would it be possible to make this more fine-grained like this to specifically target :e or :error?

Makes sense 👍

Could you reproduce your scenario by adding a (mandatory) silencing wconf in

? Thanks!

@bjaglin
Copy link
Collaborator

bjaglin commented Nov 30, 2021

It looks like the CI failure is unrelated by the way, see #261 (comment).

@ckipp01
Copy link
Member Author

ckipp01 commented Nov 30, 2021

Could you reproduce your scenario by adding a (mandatory) silencing wconf in

I think what I have should work now.

@bjaglin
Copy link
Collaborator

bjaglin commented Dec 1, 2021

Thanks! You can use a snapshot once master is built: https://oss.sonatype.org/content/repositories/snapshots/ch/epfl/scala/sbt-scalafix_2.12_1.0/

@bjaglin bjaglin merged commit 713e1b4 into scalacenter:main Dec 1, 2021
@ckipp01 ckipp01 deleted the Wconf branch December 1, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants