Refactor JDI wrappers #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpi2
force-pushed
the
refactor-expression-eval
branch
3 times, most recently
from
88ad76b
to
9e1d36c
Compare
adpi2
force-pushed
the
refactor-expression-eval
branch
from
9e1d36c
to
95bd38e
Compare
iusildra
reviewed
May 3, 2023
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/JdiArray.scala
Outdated
Show resolved
Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/EvaluationProvider.scala
Outdated
Show resolved
Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/JdiClass.scala
Show resolved
Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/JdiClass.scala
Outdated
Show resolved
Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/JdiClass.scala
Show resolved
Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/JdiValue.scala
Show resolved
Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/ScalaEvaluator.scala
Show resolved
Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/ScalaEvaluator.scala
Show resolved
Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/ScalaEvaluator.scala
Outdated
Show resolved
Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/ScalaEvaluator.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the logic in
ScalaEvaluatoris moved to JDI wrappers so that it can be reused more easily. Also the methods in the package object are now encapsulated in theJdiObjectwrapper.