Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure versions are displayed correctly in docs #1084

Closed
ckipp01 opened this issue Mar 26, 2020 · 7 comments
Closed

Ensure versions are displayed correctly in docs #1084

ckipp01 opened this issue Mar 26, 2020 · 7 comments

Comments

@ckipp01
Copy link
Member

ckipp01 commented Mar 26, 2020

Currently in the documentation it shows that that you should install scalafix in the following way:

addSbtPlugin("ch.epfl.scala" % "sbt-scalafix" % "0.9.13")

However, 0.9.13 is the current version of core, not the plugin. However, the version of core gets put into the plugin here. This may not be common as they may always be in sync, but this might confuse people as they try to install and they aren't able to find the artifact, which happens currently. However, the badge is showing the correct version.

Screenshot 2020-03-26 at 15 29 44

@cchantep
Copy link
Contributor

Now 0.9.15 is indicated, and should be compatible with Scala 2.13, but artifacts are not published.

@mlachkar
Copy link
Collaborator

mlachkar commented Jun 3, 2020

In fact, when releasing, there is a delay that can reach some hours, between the release of sbt-scalafix, and scalafix-core.
One of the objectives of scalafix v1 is to sseparate versioning of sbt-scalafix and scalafix-core similar to sbt-scalafmt and scalafmt-core.

@cchantep
Copy link
Contributor

cchantep commented Jun 3, 2020

Thx for the answer @mlachkar .
That's weird this ticket was created March 26th and many days after I still see the issue.

@mlachkar
Copy link
Collaborator

mlachkar commented Jun 3, 2020

Right now, for example, we have the issue where the documentation is not updated despite we released 0.9.16, but there is no issue when specifying this version in your plugin conf file (all the artifacts are present).
I can't explain why this happened on March 26th, but right now, the git tag is referencing a detached commit for master, which is the root cause.
We are planning to improve release documentation to avoid this issue.

@olafurpg
Copy link
Contributor

olafurpg commented Jun 3, 2020

That's weird this ticket was created March 26th and many days after I still see the issue.

@cchantep Can you elaborate? This ticket is still open.

@cchantep
Copy link
Contributor

cchantep commented Jun 3, 2020

I mean for me the delay is more days than hours, so may be we're not seeing the same symptoms?

@bjaglin
Copy link
Collaborator

bjaglin commented Feb 5, 2024

As a mitigation, sbt-scalafix and scalafix are now already released together. Actual decoupling is tracked in #1146 (although there is no active work on it).

@bjaglin bjaglin closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants