Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scala 2.12.7 #1669

Merged
merged 1 commit into from
Sep 15, 2022
Merged

scala 2.12.7 #1669

merged 1 commit into from
Sep 15, 2022

Conversation

bjaglin
Copy link
Collaborator

@bjaglin bjaglin commented Sep 15, 2022 •
edited
Loading

No description provided.

@bjaglin
Copy link
Collaborator Author

bjaglin commented Sep 15, 2022 •
edited
Loading 

[error] 	* org.scala-lang.modules:scala-xml_2.12:2.1.0 (early-semver) is selected over 1.2.0
[error] 	    +- org.scala-lang:scala-compiler:2.12.17              (depends on 2.1.0)
[error] 	    +- org.scalatest:scalatest_2.12:3.0.8                 (depends on 1.2.0)

scala/bug#12632 (comment)
I will ignore that

@tgodzik
Copy link
Contributor

tgodzik commented Sep 15, 2022

It's the same issue as scalameta/scalameta#2861 (comment)

@bjaglin
Copy link
Collaborator Author

bjaglin commented Sep 15, 2022

It's the same issue as scalameta/scalameta#2861 (comment)

I bet this will be a trending google search query in the coming days :)

bjaglin
bjaglin commented Sep 15, 2022
View reviewed changes
project/ScalafixBuild.scala
Comment on lines +197 to +191
// https://github.com/scala/bug/issues/12632
libraryDependencySchemes += "org.scala-lang.modules" %% "scala-xml" % "always"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1671

@bjaglin bjaglin force-pushed the scala2127 branch 3 times, most recently from b17dda9 to 3d2240f Compare September 15, 2022 11:07
bjaglin
bjaglin commented Sep 15, 2022
View reviewed changes
project/ScalafixBuild.scala
)

override def projectSettings: Seq[Def.Setting[_]] = List(
versionPolicyIntention := versionPolicyIntentionSetting.value,
versionPolicyIntention := Compatibility.None,
Copy link
Collaborator Author

@bjaglin bjaglin Sep 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as 2e2691c

@bjaglin bjaglin marked this pull request as ready for review September 15, 2022 14:34
@bjaglin bjaglin merged commit 62fb190 into main Sep 15, 2022
@bjaglin bjaglin deleted the scala2127 branch August 1, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjaglin @tgodzik