Update scalameta to 4.8.5

[scala-center-steward]

About this PR

📦 Updates org.scalameta:scalameta from 4.8.2 to 4.8.5

📜 GitHub Release Notes - Version Diff

Usage

✅ Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalameta" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta", artifactId = "scalameta" }
}]

^{labels: library-update, early-semver-patch, semver-spec-patch, version-scheme:semver-spec, commit-count:1}

[bjaglin]

Putting this on hold a bit.

The biggest impact of this comes from scalameta/scalameta#3250, which is effectively breaking, as it can cause regressions for people upgrading sbt-scalafix in their build since install instructions advise to use the scalameta version used in scalafix to fetch scalac-semanticdb. We might want to revisit that to put emphasis on using scalafixEnable which does not suffer from the regression thanks to scalacenter/sbt-scalafix#292 (and adds less friction for newcomers anyway).

Discussed on Scalameta's discord:

For users integrating scalafix in their build, the recommended setup is to use the scalameta version referenced by scalafix in sbt's SemanticdbPlugin, as the default baked-in in sbt tends to lag), so I expect some limited impact. As a first step, we could try to improve the error message in sbt when scalac-semanticdb is not found since it's currently not actionable at all:

[error] (update) sbt.librarymanagement.ResolveException: Error downloading org.scalameta:semanticdb-scalac_2.13.11:4.5.13
[error]   Not found
[error]   Not found
[error]   not found: /home/brice/.ivy2/local/org.scalameta/semanticdb-scalac_2.13.11/4.5.13/ivys/ivy.xml
[error]   not found: https://repo1.maven.org/maven2/org/scalameta/semanticdb-scalac_2.13.11/4.5.13/semanticdb-scalac_2.13.11-4.5.13.pom
[error] Total time: 1 s, completed Jul 19, 2023, 3:49:41 PM

I was thinking of recovering that exception by redefining update in SemanticdbPlugin to add error handling (like described in https://www.scala-sbt.org/1.x/docs/Tasks.html#Handling+Failure). Thoughts?

[tgodzik]

Actually, it would be awesome to fetch the latest supported version to be built into sbt when using semanticdbEnabled, though I don't want to delve into sbt currently. I plan to update things in the metals sbt plugin for Metals and we could port the same thing to sbt-scalafix, what do you think?

[bjaglin]

I plan to update things in the metals sbt plugin for Metals and we could port the same thing to sbt-scalafix, what do you think?

Actually, the logic is already there, but I am concerned about the IO overhead at sbt startup if we were to make that the default, as compiler plugins can only be added through setting keys from what I know.

[tgodzik]

I plan to update things in the metals sbt plugin for Metals and we could port the same thing to sbt-scalafix, what do you think?

Actually, the logic is already there, but I am concerned about the IO overhead at sbt startup if we were to make that the default, as compiler plugins can only be added through setting keys from what I know.

I wonder if we could cache that information, maybe that would help? 🤔

But anyway, thanks for sharing that, I might need to use the same mechanism.

[scala-center-steward]

Superseded by #1835.