run more expect tests against Scala 3 #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
commented
Mar 3, 2024
| @@ -17,6 +17,8 @@ Disable.symbols = [ | |||
|
|
|||
| package test.escapeHatch | |||
|
|
|||
| import test.disableSyntax.DisableSyntaxMoreRules.toString | |||
There was a problem hiding this comment.
[error] 37 | None + "foo",
[error] | ^^^^^^
[error] |value + is not a member of object None, but could be made available as an extension method.
[error] |
[error] |The following import might fix the problem:
[error] |
[error] | import test.disableSyntax.DisableSyntaxMoreRules.toString
[error] |
bjaglin
commented
Mar 3, 2024
| def this(eDummy: String, fDummy: String) { | ||
| this | ||
| def this(eDummy: String, fDummy: String) = { | ||
| this() |
There was a problem hiding this comment.
[error] 123 | this
[error] | ^
[error] |None of the overloaded alternatives of constructor DummyClass_6 in class DummyClass_6 with types
[error] | (eDummy: String, fDummy: String): test.escapeHatch.AnnotationScopes.DummyClass_6
[error] | (): test.escapeHatch.AnnotationScopes.DummyClass_6
[error] |match arguments ((??? : => Nothing))
bjaglin
commented
Mar 3, 2024
| @@ -25,8 +25,6 @@ object AnnotationScopes { | |||
|
|
|||
| class Foo_0[DummyTypeParam] // assert: NoDummy | |||
|
|
|||
| def dummyMacro_0: Unit = macro ??? // assert: NoDummy | |||
There was a problem hiding this comment.
[error] | ^
[error] | No Scala 3 implementation found for this Scala 2 macro.
I decided it was niche enough to just drop the test case
bjaglin
force-pushed
the
scala3-moreexpecttests
branch
from
06015e8
to
36c59ec
Compare
bjaglin
commented
Apr 13, 2024
|
|
||
| object AnchorPatches { | ||
| def d1s = Duration(1, "s") | ||
| def d2s = Duration(2, "s") // scalafix:ok ExplicitResultTypes |
There was a problem hiding this comment.
rewrote the test to leverage RemoveUnused only, as ExplicitResultTypes is not available on Scala 3, thus the undetected rename
bjaglin
force-pushed
the
scala3-moreexpecttests
branch
from
36c59ec
to
f095917
Compare
bjaglin
commented
Apr 13, 2024
Comment on lines
+11
to
+12
| // Fails with Scala3 dialect as the second silencer is not attached to the Defn.Val | ||
| // https://github.com/scalameta/scalameta/issues/3689 |
There was a problem hiding this comment.
bjaglin
force-pushed
the
scala3-moreexpecttests
branch
2 times, most recently
from
9e440d8
to
54d1bca
Compare
bjaglin
commented
Apr 13, 2024
Comment on lines
+13
to
+15
| // Unsupported on Scala 3 | ||
| // https://github.com/scala/scala3/issues/12766 | ||
| // https://github.com/scalacenter/scalafix/blob/f51cb4a/docs/rules/OrganizeImports.md?plain=1#L440-L444 |
There was a problem hiding this comment.
bjaglin
force-pushed
the
scala3-moreexpecttests
branch
from
54d1bca
to
b332360
Compare
bjaglin
commented
Apr 13, 2024
Comment on lines
+6
to
+7
| // Not available as of Scala 3.4.1 | ||
| // https://github.com/scalacenter/scalafix/issues/1937 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: ensure good coverage & detect potential Scalameta regressions