Cross-build sbt plugin for 0.13 and 1.0 #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabro
commented
Sep 23, 2017
| if (isSupportedScalaVersion.value) { | ||
| scalafixScalacOptions.value | ||
| options |
There was a problem hiding this comment.
This is to fix
[error] Problem: `scalafixScalacOptions` is inside the if expression of a regular task.
[error] Regular tasks always evaluate task inside the bodies of if expressions.
[error]
[error] Solution:
[error] 1. If you only want to evaluate it when the if predicate is true or false, use a dynamic task.
[error] 2. Otherwise, make the static evaluation explicit by evaluating `scalafixScalacOptions` outside the if expression.
[error]
[error] scalafixScalacOptions.value
[error] ^
[error] one error found
There was a problem hiding this comment.
By the way, ❤️ @jvican for that beautiful error message 👆
gabro
force-pushed
the
cross-build-sbt-plugin
branch
from
af4364c
to
084e529
Compare
olafurpg
reviewed
Sep 23, 2017
|
I've moved sbt versions to The last one is admittedly a shot in the dark, but I don't have a decent way of testing it. |
olafurpg
approved these changes
Sep 23, 2017
|
mm, I had high hopes but nope, didn't work: Any sbt expert around? |
|
@olafurpg I've removed the tag, but left the release notes in draft (https://github.com/scalacenter/scalafix/releases/tag/untagged-0b502c49a33fb0c5374e) |
|
I'll take a look at this Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #374
Not sure what I should change to make this automatically published by the CI