Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second stab at 2.12.4. #477

Merged
merged 2 commits into from
Dec 7, 2017
Merged

Second stab at 2.12.4. #477

merged 2 commits into from
Dec 7, 2017

Commits on Dec 7, 2017

  1. Second stab at 2.12.4. 

    Last time we upgraded to 2.12.4 the CI failed with a missing shapeless
implicit error from case-app. I can reproduce this error locally only on
the first `sbt compile`. Running the command the seconds time succeeds
compilation. I want to see if CI fails again, and investigate if
`-YdisableFlatCpCaching` can fix the error.
    @olafurpg
    olafurpg committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    620c630 View commit details
    Browse the repository at this point in the history

  2. Increase stack size. 

    With -Xlog-implicits I was able to track down that the inductive
derivation for the case-app parser was failing with a stack overflow
```
[info] hasMatchingSymbol reported error: exception during macro expansion:
[info] java.lang.StackOverflowError
[info]     at scala.tools.nsc.typechecker.StdAttachments.isMacroImplRef(StdAttachments.scala:153)
[info]     at scala.tools.nsc.typechecker.StdAttachments.isMacroImplRef$(StdAttachments.scala:153)
[info]     at scala.tools.nsc.Global$$anon$1.isMacroImplRef(Global.scala:458)
[info]     at scala.tools.nsc.typechecker.Typers$Typer.adapt(Typers.scala:1175)
```

This could offer an explanation why 2.12.4 is a regression, since the
stack size might have changed.
    @olafurpg
    olafurpg committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    c76098a View commit details
    Browse the repository at this point in the history