Fix majority of compilation warnings #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #288 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 39 39
Lines 1147 1147
Branches 137 137
=======================================
Hits 1128 1128
Misses 19 19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
MateuszKubuszok
approved these changes
Mar 17, 2023
krzemin
added a commit
that referenced
this pull request
Mar 17, 2023
- cleanup majority of the compilation warnings - cleanup unused warnings from macro-generated code (Scala 2 only)
krzemin
added a commit
that referenced
this pull request
Mar 17, 2023
- cleanup majority of the compilation warnings - cleanup unused warnings from macro-generated code (Scala 2 only)
krzemin
added a commit
that referenced
this pull request
Apr 19, 2023
- cleanup majority of the compilation warnings - cleanup unused warnings from macro-generated code (Scala 2 only)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes (or silences globally) majority of the compilation warnings and brings back
-Xfatal-warningsfor Scala 2.13.For 2.12 it seems that semantics of
@unusedannotation is a bit different for tests asserting compilation errors.It also fixes two classes of unused warnings in macro-generated code:
TransformerConfiguration, when it's defined