Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java collections as integrations #510

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

MateuszKubuszok
Copy link
Member

@MateuszKubuszok MateuszKubuszok commented Apr 24, 2024

Reimplements Java collections support through new Chimney integrations API.

@MateuszKubuszok MateuszKubuszok added this to the 1.0.0-RC milestone Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 90.37433% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 87.54%. Comparing base (0a1b233) to head (0d26fef).

Files Patch % Lines
...ney/javacollections/JavaCollectionsImplicits.scala 92.21% 13 Missing ⚠️
...ernal/compiletime/datatypes/IterableOrArrays.scala 76.92% 3 Missing ⚠️
.../chimney/integrations/PartiallyBuildIterable.scala 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
- Coverage   88.06%   87.54%   -0.53%     
==========================================
  Files         141      134       -7     
  Lines        5530     5458      -72     
  Branches      459      474      +15     
==========================================
- Hits         4870     4778      -92     
- Misses        660      680      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateuszKubuszok MateuszKubuszok merged commit 85c859c into master Apr 24, 2024
22 of 23 checks passed
@MateuszKubuszok MateuszKubuszok deleted the java-collections-as-integrations branch April 24, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant