Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty mdoc code fences #192

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Handle empty mdoc code fences #192

merged 1 commit into from
Sep 24, 2019

Conversation

hmf
Copy link

@hmf hmf commented Sep 24, 2019

Seems to solve issue #189.

@olafurpg olafurpg changed the title Issue #189: empty code fence can now be empty Handle empty mdoc code fences Sep 24, 2019
@olafurpg olafurpg merged commit 2775ab5 into scalameta:master Sep 24, 2019
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you for the fix! I merged locally since I couldn't figure out how to push a change to your master branch, in the future please try to open PRs from a non-master branch.

@olafurpg
Copy link
Member

Triggered a new release v1.3.4 with this fix.

@hmf
Copy link
Author

hmf commented Sep 24, 2019

in the future please try to open PRs from a non-master branch.

Sorry. Lack of knowledge. Will do.

@olafurpg
Copy link
Member

No worries, thank you for you contribution 🙏 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants