Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make older Scala 2.12 versions work #447

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jan 17, 2021

Previously, we would only publish for the newest Scala 2.12 version, howeverthis might cause issues for versions older than 2.12.12. To help with that, I added a full cross version and made sure that a proper versions is picked up by the sbt plugin.

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this change! LGTM

just a thought, would it be possible to to add a library versioned artifact that is an alias for the latest version? That would remove the breaking change.

Previously, we would only publish for the newest Scala 2.12 version, howeverthis might cause issues for versions older than 2.12.12. To help with that, I added a full cross version and made sure that a proper versions is picked up by the sbt plugin.
@tgodzik
Copy link
Contributor Author

tgodzik commented Jan 18, 2021

Thank you for doing this change! LGTM

just a thought, would it be possible to to add a library versioned artifact that is an alias for the latest version? That would remove the breaking change.

Actually, I think it is possible! I added:

  CrossVersion.binaryWith(
    prefix = "",
    suffix = if (scalaVersion.value == scala212Legacy) ".12" else ""
  )

which for binary cross version will add .12 as a suffix, so it will only have a full versions for 2.12.12. I made similar changes in the plugin and tested it out in Metals.

@tgodzik tgodzik requested a review from olafurpg January 18, 2021 11:19
@tgodzik
Copy link
Contributor Author

tgodzik commented Jan 18, 2021

Tested it out with Metals so it seems to work, I will cut the new release and can fix anything that comes up later.

@tgodzik tgodzik merged commit 3049439 into scalameta:master Jan 18, 2021
@tgodzik tgodzik deleted the fix-mdoc branch January 18, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants