Document symbol provider #27
Conversation
| val pos = Position("???", symPos.start.offset, symPos.end.offset) | ||
| new SymbolInformation( | ||
| name = denotation.name, | ||
| containerName = "???", |
There was a problem hiding this comment.
We can probably implement a utility to shorten those fully qualified names org.typelevel.paiges.Doc into Doc
There was a problem hiding this comment.
The fully qualified names make sense to me especially for cross project metadoc sites.
| val denotations = attrs.denotations.map { case (s, d) => s -> d }.toMap | ||
| val symbols = for { | ||
| (symPos, sym) <- attrs.names | ||
| denotation <- denotations.get(sym) |
There was a problem hiding this comment.
We should probably filter out parameters, a symbol is any definition, including def parameters/class fields and bound names in pattern matching.
This seems to do an OK job
(!isPARAM && !isTypeParam) && {
isClass ||
isTrait ||
isObject ||
isDef ||
isVal
}There was a problem hiding this comment.
Glad you pitched in on getting this working!
| else if (denotation.isClass) | ||
| Some(SymbolKind.Class) | ||
| else if (denotation.isObject) | ||
| Some(SymbolKind.Module) |
| ) = { | ||
| val denotations = attrs.denotations.map { case (s, d) => s -> d }.toMap | ||
| val symbols = for { | ||
| (symPos, sym) <- attrs.names |
There was a problem hiding this comment.
It seems we currently don't have the model's filename, model.uri is inmemory://model/1. Once we solve #19 then we can filter out the symbols by filename.
There was a problem hiding this comment.
Depending on your progress we can also start by creating the model separately which allows to define the URI.
There was a problem hiding this comment.
I've been digging into the vscode api, and learning how to use desktop vscode at the same time 😅
Seems the ITextModelService is what we need to provide.
|
Here is how it looks now
|
- Add more interesting corpus. - Use Index instead of Attributes.names. - Filter out parameters.
olafurpg
force-pushed
the
document-symbol-provider
branch
from
82f4031
to
5942b07
Compare
| index.files | ||
| .find(_.endsWith("Doc.scala")) | ||
| .get | ||
| .replace(".scala", ".semanticdb") |
There was a problem hiding this comment.
We should probably add an entrypoint setting to the CLI and store it in metadoc.index for use here, unless we show some kind of directory browser on start.
There was a problem hiding this comment.
I think it makes sense to start with an empty page + instructions on opening files
There was a problem hiding this comment.
I propose we fix that once we nail #19
|
Are we good to merge this? |
| isVal | ||
| } | ||
| } | ||
| kind <- symbolKind(denotation) |
There was a problem hiding this comment.
We are filtering twice here, since anything we cannot map to a SymbolKind won't be shown. I suggest we change the above filter to only remove parameters and type parameters.
There was a problem hiding this comment.
Although I think there's a SymbolKind for parameters.
|
Definitely, let's merge. It looks great. |
Refs #21
Will need some help on how to extract the symbol info from Scalameta's
SymbolandDenotation.