Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: end test run in finally block #1053

Merged
merged 2 commits into from
Jul 8, 2022
Merged

fix: end test run in finally block #1053

merged 2 commits into from
Jul 8, 2022

Conversation

kpodsiad
Copy link
Member

@kpodsiad kpodsiad commented Jul 7, 2022

  • move try block to toplevel function
  • execute finalization logic in finally block

@kpodsiad kpodsiad mentioned this pull request Jul 7, 2022
Merged
@kpodsiad kpodsiad requested a review from tgodzik July 7, 2022 13:50
tgodzik
tgodzik approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kpodsiad kpodsiad merged commit ae95278 into scalameta:main Jul 8, 2022
@kpodsiad kpodsiad deleted the fix/end-test-run branch July 8, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpodsiad @tgodzik