Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor install java out of extension.ts #1060

Merged
merged 2 commits into from
Jul 13, 2022
Merged

chore: refactor install java out of extension.ts #1060

merged 2 commits into from
Jul 13, 2022

Conversation

kpodsiad
Copy link
Member

It's always less in extension.ts

tgodzik
tgodzik approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just need to rebase, but LGTM otherwise!

@kpodsiad kpodsiad merged commit e9bf738 into scalameta:main Jul 13, 2022
@kpodsiad kpodsiad deleted the chore/refactor-install-java-out branch July 13, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@tanishiking tanishiking Awaiting requested review from tanishiking

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpodsiad @tgodzik