bugfix: Show error properly if lenses cannot be run #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpodsiad
approved these changes
Jan 4, 2024
Comment on lines
598
to
599
| (reason: Error) => { | ||
| window.showErrorMessage(reason.message); |
There was a problem hiding this comment.
did you check that typeof reason in runtime is Error? Where does it come from?
There was a problem hiding this comment.
That's what I was getting in runtime, should I do a check to make sure it's an Error?
There was a problem hiding this comment.
I added a check just in case.
tgodzik
force-pushed
the
show-error-on-lenses
branch
from
7e55077
to
81a9fbc
Compare
tgodzik
force-pushed
the
show-error-on-lenses
branch
from
81a9fbc
to
dcd6f94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.