Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade coursier binary to 2.0.0-RC3-4 #149

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Conversation

olafurpg
Copy link
Member

@olafurpg olafurpg commented Oct 10, 2019

This could help users behind corporate VPNs, the latest coursier for example supports mirror files https://get-coursier.io/blog/2019/07/05/1.1.0-M14.html#mirrors

@olafurpg olafurpg changed the title Upgrade coursier binary Upgrade coursier binary to 2.0.0-RC3-4 Oct 10, 2019
@olafurpg olafurpg requested a review from gabro October 10, 2019 10:11
Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 trusting the binary is correct

@olafurpg olafurpg merged commit 207e400 into scalameta:master Oct 10, 2019
@tgodzik
Copy link
Contributor

tgodzik commented Oct 14, 2019

@olafurpg It seems logs look pretty bad with the new version:

�[2KDownloaded 1 missing file(s) / 8
�[1A
�[2KDownloaded 2 missing file(s) / 8
�[1A
�[2KDownloaded 3 missing file(s) / 8
�[1A
�[2KDownloaded 4 missing file(s) / 8
�[1A
�[2KDownloaded 5 missing file(s) / 8
�[1A
�[2KDownloaded 6 missing file(s) / 8
�[1A
�[2KDownloaded 7 missing file(s) / 8
�[1A
�[2KDownloaded 8 missing file(s) / 8
�[1A�[2K

@olafurpg
Copy link
Member Author

Can you open an issue? I’ll follow up

@olafurpg
Copy link
Member Author

Done.

@olafurpg olafurpg deleted the bump branch October 17, 2019 10:53
kasiaMarek pushed a commit to kasiaMarek/metals-vscode that referenced this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants