improvement: Retry with coursier jar if anything fails #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiaMarek
reviewed
Jun 3, 2024
| outputChannel.appendLine( | ||
| "Trying again with the embedded coursier. This might take longer." | ||
| ); | ||
| return fetchAndLaunchMetals(context, serverVersion, javaVersion, true); |
There was a problem hiding this comment.
If you rerun the whole fetchAndLaunchMetals it will again try to download coursier, this seems redundant.
There was a problem hiding this comment.
Reworked it while resolving coursier:
if (forceCoursierJar) {
coursier = undefined;
} else {
coursier = await resolveCoursier();
}
Previously, if anything failed with coursier native image, for example we wouldn't have proper encoding then user would not be able to do anything. Now, if there is Java avaialable we can retry with the embedded coursier jar.
kasiaMarek
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if anything failed with coursier native image, for example we wouldn't have proper encoding then user would not be able to do anything.
Now, if there is Java avaialable we can retry with the embedded coursier jar.
Might help with #1509