Fix issues with hovers in worksheets #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would send MarkupContent with `value` and `kind` parameter specified and feed it to decorations.
It seems that this would not work as it would not fit the expected format, which can be string, {language, string} or MarkdownString.
This should probably not worked before, but probably it was only by chance and as the behaviour was not documented it could be expected to last.
gabro
reviewed
Dec 18, 2020
gabro
approved these changes
Dec 18, 2020
kasiaMarek
pushed a commit
to kasiaMarek/metals-vscode
that referenced
this pull request
Mar 29, 2023
…rn/types/node-18.0.4 chore(deps-dev): bump @types/node from 18.0.3 to 18.0.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would send MarkupContent with
valueandkindparameter specified and feed it to decorations.It seems that this would not work as it would not fit the expected format, which can be string, {language, string} or MarkdownString.
This should probably not worked before, but probably it was only by chance and as the behaviour was not documented it could be expected to last.