Update default for "editor.suggestSelection" to "first", fixes #86. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eta#86. Previously, the default "editor.suggestSelection" value was "last" causing VS Code to pre-select counter-intuitive completions items. For example, if you selected `toString()` once, then VS Code would pre-select `toString()` in the following completion regardless of the order of completions returned by Metals. Metals already orders completion items in a "smart" order based on the local scope and completion position (pattern matching vs. type vs. term). Now with this change, VS Code always pre-selects the first completion item returned by Metals.
|
Although completions are not part of the latest stable release, this fix will already benefit people using the latest snapshot. |
gabro
approved these changes
Apr 2, 2019
|
Urm... are you sure thie ever worked? microsoft/vscode#91180 (comment) |
kasiaMarek
pushed a commit
to kasiaMarek/metals-vscode
that referenced
this pull request
Mar 29, 2023
…n/types/node-13.13.2 Bump @types/node from 13.13.1 to 13.13.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the default "editor.suggestSelection" value was "last"
causing VS Code to pre-select counter-intuitive completions items.
For example, if you selected
toString()once, then VS Code wouldpre-select
toString()in the following completion regardless of theorder of completions returned by Metals.
Metals already orders completion items in a "smart" order based on the
local scope and completion position (pattern matching vs. type vs.
term). Now with this change, VS Code always pre-selects the first
completion item returned by Metals.