Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"editor.suggestSelection" doesn't seem to work as a language-specific setting #91180

Closed
Gama11 opened this issue Feb 21, 2020 · 3 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities suggest IntelliSense, Auto Complete verified Verification succeeded
Milestone

Comments

@Gama11
Copy link
Contributor

Gama11 commented Feb 21, 2020

I was trying to contribute a default configuration for "editor.suggestSelection" in the Haxe extension as described here by @jrieken: MicrosoftDocs/intellicode#138

However, I couldn't make this work, which made me test if it even works if it's configured by the user in settings.json rather than via a configurationDefaults. I couldn't make this work as a language specific setting either, not even for TypeScript.

The following .gif shows how TextEncoder is pre-selected when completion is invoked (because I had previously selected it), despite the config in the lower panel. Only the non-language-specific setting seems to have an effect.


VS Code version: Code 1.42.1 (c47d83b, 2020-02-11T14:45:59.656Z)
OS version: Windows_NT x64 10.0.18363

@jrieken
Copy link
Member

jrieken commented Feb 25, 2020

The following .gif shows how TextEncoder is pre-selected when completion is invoked

Please as steps. A gif complements but doesn't replace steps. Adding them will cost way less time than the time it takes me to stare at a looping gif

@jrieken jrieken added the info-needed Issue requires more information from poster label Feb 25, 2020
@Gama11
Copy link
Contributor Author

Gama11 commented Feb 25, 2020

First, to "initialize" the completion memory, request completion after Tex in a TS file and select TextEncoder. Undo and press Ctrl+Space again, this time TextEncoder should be pre-selected due to the default value of "editor.suggestSelection" (recentlyUsed).


Add the following to your settings:

"[typescript]": {
    "editor.suggestSelection": "first"
}

Expectation: this should clear the pre-selection / select the first item when we request completion again, but instead there's no change:


Now move the setting out of the [typescript] block. Only now does the setting have an effect:

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete help wanted Issues identified as good community contribution opportunities and removed info-needed Issue requires more information from poster labels Feb 26, 2020
@jrieken
Copy link
Member

jrieken commented Feb 26, 2020

Yes - turns out this isn't implemented ;-)

@jrieken jrieken added this to the March 2020 milestone Feb 26, 2020
@jrieken jrieken closed this as completed in 361a544 Mar 4, 2020
Gama11 added a commit to vshaxe/vshaxe that referenced this issue Mar 14, 2020
@roblourens roblourens added the verified Verification succeeded label Apr 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities suggest IntelliSense, Auto Complete verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants