Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump linters & update lint rules #943

Merged
merged 5 commits into from
Apr 16, 2022
Merged

chore(deps): bump linters & update lint rules #943

merged 5 commits into from
Apr 16, 2022

Conversation

yoshinorin
Copy link
Contributor

@yoshinorin yoshinorin commented Apr 15, 2022 •
edited
Loading

Purpose

Current version of @typescript-eslint does not support typescript 4.6.3.
This PR purpose is update linters (eslint & typescript-eslint)

$ yarn run lint
yarn run v1.22.11
warning metals@1.13.10: The engine "vscode" appears to be invalid.
$ eslint . --ext .ts --fix && yarn format
=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <4.5.0

YOUR TYPESCRIPT VERSION: 4.6.3

Please only submit bug reports when using the officially supported version.

=============

Thank you :)

Others

I checked the eslint v8.0.0 migration guide and the typescript-eslint 5.0.0 release note. One of the breaking change found but basically seems no problem.

yoshinorin
yoshinorin commented Apr 15, 2022
View reviewed changes
.eslintrc.js Outdated
@@ -16,6 +16,8 @@ module.exports = {
"warn",
{ ignoreRestArgs: true },
],
"no-unused-vars": "off",
"@typescript-eslint/no-unused-vars": ["warn"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change in typescript-eslint v5.0.0.

https://github.com/typescript-eslint/typescript-eslint/releases/tag/v5.0.0
https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-unused-vars.md

@yoshinorin
Copy link
Contributor Author

yoshinorin commented Apr 15, 2022 •
edited
Loading

Opps.. I'm going to resolve conflict.

P.S:

Done :)

@kpodsiad
Copy link
Member

@yoshinorin could you fix eslint CI too? It should fail when there are some warnings but currently it doesn't. I guess it's a matter of some flag.

@yoshinorin
Copy link
Contributor Author

@kpodsiad

could you fix eslint CI too? It should fail when there are some warnings but currently it doesn't. I guess it's a matter of some flag.

OK. I will try 👌

yoshinorin
yoshinorin commented Apr 16, 2022
View reviewed changes
src/scalaDebugger.ts
@@ -75,7 +75,7 @@ class ScalaMainConfigProvider implements vscode.DebugConfigurationProvider {
path: editor.document.uri.toString(true),
runType: RunType.RunOrTestFile,
};
return start(false, args).then((_) => {
return start(false, args).then(() => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete unused var

src/util.ts
const { defaultValue, workspaceValue } = config.inspect<A>(key)!;
/* eslint-enable @typescript-eslint/no-non-null-assertion */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add eslint-disable @typescript-eslint/no-non-null-assertion for non-null-assertion.

@yoshinorin
Copy link
Contributor Author

Done :)
I updated eslint rules.

@yoshinorin yoshinorin changed the title chore(deps): bump linter chore(deps): bump linters & update lint rules Apr 16, 2022
kpodsiad
kpodsiad approved these changes Apr 16, 2022
View reviewed changes
Copy link
Member

@kpodsiad kpodsiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @yoshinorin!
Are you on Scalameta Discord? I wanted to ask you one question, but it'll be easier on DM or some chat rather than Github discussions.

@kpodsiad kpodsiad merged commit 1c8e368 into scalameta:main Apr 16, 2022
@yoshinorin yoshinorin deleted the chore/bump-linter branch April 17, 2022 10:47
@yoshinorin
Copy link
Contributor Author

@kpodsiad

Are you on Scalameta Discord?

I joined Scalameta Discord just now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodsiad kpodsiad kpodsiad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoshinorin @kpodsiad