feat: add install Java17 option when choose JavaDownload

[yoshinorin]

As is the title.

Problem

If we do not apply modal: true to showInformationMessage, users can not decide which button should select that they want to download. Because, showInformationMessage width is narrow and can not contain 4 buttons.

Solution (idea)

We can apply modal: true to showInformationMessage. This option showInformationMessage with a dialog. It can contain 4 buttons.

How do you think?

Thank you :)

[kpodsiad]

I'm ok with the modal, because having a JDK is crucial for Metals and any problem related to its absence is serious, thus modal makes sense - it forces you to make some decisions.

wdyt @tgodzik

[tgodzik]

Looks good, but I would even remove the option for JDK 8 to prepare for a possible deprecation.

[dos65]

@tgodzik @kpodsiad
There is also an option to put these choices into quick pick menu. wdyt?

[tgodzik]

@tgodzik @kpodsiad There is also an option to put these choices into quick pick menu. wdyt?

I think the quick pick is not the right fir for it, it's to easy to make it disappear

[kpodsiad]

@tgodzik @dos65 what is the consensus? If I understand correctly it is:

• removing JDK8
• using modal is fine since having JDK is crucial

[tgodzik]

@tgodzik @dos65 what is the consensus? If I understand correctly it is:

• removing JDK8
• using modal is fine since having JDK is crucial

That's my opinion here, yes.

[kpodsiad]

I want to include this in the current release thus I'll commit changes that we concluded.

[dos65]

👍

[kpodsiad]

Thanks @yoshinorin for your contribution!