Add Hover Test and fix broken cases #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabro
force-pushed
the
hover-3
branch
2 times, most recently
from
baa447d
to
86ede97
Compare
olafurpg
requested changes
Nov 24, 2017
| @@ -217,4 +204,17 @@ object Compiler extends LazyLogging { | |||
| f(r) | |||
| r | |||
| } | |||
| def typeOfTree(c: Global)(t: c.Tree): Option[String] = { | |||
There was a problem hiding this comment.
In #51 I moved all logic into compiler.SignatureHelpProvider, I think it would make sense to have a corresponding compiler.HoverProvider object, even if the method is small.
There was a problem hiding this comment.
Yes, that's what I intend to do in this PR. I opened it for early feedback, but it's not quite ready for merge :) thanks for the review!
|
Ok, I'm fairly happy with this. I'm sure there's some trick cases we're not accounting for, but now it should be easy to quickly add a failing test and tweak |
olafurpg
approved these changes
Nov 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that #38 wasn't such a good idea. For some cases the "long string" isn't what we want on hover, e.g. for
the result is
a.x.type (with underlying type List[Int]), whereas we would just likeList[Int].In this PR I've added a few tests (built on the infrastructure of #51) that also highlight the failing cases.
I intend to fix them in this PR and I think the simplest solution is to go back to using
.tpe.widenand maybe handling a few edge cases manually.By the way, 👏 @olafurpg for the testing infra with chevrons: really handy to use!