Insert pipe character when editing multiline strings #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzarnowski
requested changes
Aug 13, 2019
metals/src/main/scala/scala/meta/internal/metals/OnTypeFormattingProvider.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/OnTypeFormattingProvider.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/OnTypeFormattingProvider.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/OnTypeFormattingProvider.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/OnTypeFormattingProvider.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/OnTypeFormattingProvider.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/OnTypeFormattingProvider.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/OnTypeFormattingProvider.scala
Outdated
Show resolved
Hide resolved
|
Checking this in VSCode - it seems doesn't yet work. We need to change some things. |
mzarnowski
requested changes
Aug 19, 2019
metals/src/main/scala/scala/meta/internal/metals/MetalsLanguageServer.scala
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/OnTypeFormattingProvider.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/OnTypeFormattingProvider.scala
Outdated
Show resolved
Hide resolved
…s. Doesn't work for copypasted ones yet, though.
mzarnowski
changed the title
mzarnowski
changed the title
mzarnowski
approved these changes
Aug 21, 2019
mzarnowski
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially solves #859. Doesn't work for copypasted strings yet, though.
The behaviour isn't identical to that demonstrated in gifs under issue #859. For now, before making a TextEdit, Provider checks whether there was a pipe in the last line, even, if it's the first line of the string. It doesn't yet add .stripMargin after the end of the string, either. So we might want to expand on that.