Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update website to point to latest stable release #443

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

olafurpg
Copy link
Member

No description provided.

@@ -52,4 +52,5 @@ final class Test(
buf += location
buf.toArray
}
l
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover?

Comment on lines -333 to +334
"VERSION" -> version.value.replaceFirst("\\+.*", "")
"VERSION" -> version.value.replaceFirst("\\+.*", ""),
"STABLE_VERSION" -> "0.7.29"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would've probably left VERSION as-is, and introduced a NEXT_MAJOR_VERSION or something, so that you wouldn't have to change existing uses of VERSION, but it's a minor thing, feel free to ignore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree. Thought about the same after going through the docs refactoring. Gonna keep the changes though since they're already done, it wasn't a huge diff

@olafurpg olafurpg enabled auto-merge (squash) October 18, 2021 08:02
@olafurpg olafurpg merged commit 41f56c3 into scalameta:main Oct 18, 2021
@olafurpg olafurpg deleted the stable-version branch October 18, 2021 08:03
@keyno63 keyno63 mentioned this pull request Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants