Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use def to override scalaCheckInitialSeed #564

Merged
merged 4 commits into from
Aug 17, 2022
Merged

Use def to override scalaCheckInitialSeed #564

merged 4 commits into from
Aug 17, 2022

Conversation

armanbilge
Copy link
Contributor

Fixes #563

FrancescoSerra
FrancescoSerra approved these changes Jul 26, 2022
View reviewed changes
Copy link

@FrancescoSerra FrancescoSerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

valencik
valencik approved these changes Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@valencik valencik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like purely a documentation and testing change? As in, all we're doing is making the best practice more clear?

@armanbilge
Copy link
Contributor Author

Yup. Basically a def is less likely to go wrong due to subtle initialization order issues.

@valencik valencik merged commit 2fea01d into scalameta:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancescoSerra FrancescoSerra FrancescoSerra approved these changes

@valencik valencik valencik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

override val scalaCheckInitialSeed = ... leads to NullPointerException
3 participants
@armanbilge @valencik @FrancescoSerra