Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScalafmtConfig: restore withDialect overload #2735

Merged
merged 2 commits into from
Sep 15, 2021
Merged

ScalafmtConfig: restore withDialect overload #2735

merged 2 commits into from
Sep 15, 2021

Conversation

kitbellew
Copy link
Collaborator

Fixes #2734.

tgodzik
tgodzik approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This should work as a short term solution, though it would be best if Scala plugin started using the dynamic module.

@tgodzik
Copy link
Contributor

tgodzik commented Sep 15, 2021

You might hold off on a new release until we release new Scalameta with some fixes.

@kitbellew kitbellew merged commit 01e3a2b into scalameta:master Sep 15, 2021
@kitbellew kitbellew deleted the 2734 branch September 15, 2021 13:32
@michaelahlers michaelahlers mentioned this pull request Sep 16, 2021
Merged
@kitbellew
Copy link
Collaborator Author

You might hold off on a new release until we release new Scalameta with some fixes.

when are you planning to do that?

@tgodzik
Copy link
Contributor

tgodzik commented Sep 17, 2021

The release is out under 4.4.28. 🥳

@tgodzik
Copy link
Contributor

tgodzik commented Sep 17, 2021

#2745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot open build.sbt in intellij after updating to 3.0.3
2 participants
@kitbellew @tgodzik