Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormatOps: ignore end marker for ctrl body purpose #3023

Merged
merged 2 commits into from
Dec 31, 2021

Conversation

kitbellew
Copy link
Collaborator

This makes formatting with or without an end marker consistent. Follow-on to #3021.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kitbellew
Copy link
Collaborator Author

@tgodzik thank you, tomasz, i enjoyed our tandem this year, did a lot of great things! happy new year , best wishes to you and your family!

@kitbellew kitbellew merged commit e9ac433 into scalameta:master Dec 31, 2021
@kitbellew kitbellew deleted the 3022 branch December 31, 2021 13:02
@tgodzik
Copy link
Contributor

tgodzik commented Dec 31, 2021

@tgodzik thank you, tomasz, i enjoyed our tandem this year, did a lot of great things! happy new year , best wishes to you and your family!

Happy new year to you too! And also thank you for being a driving force behind scalafmt and for all the advice/help you have given me!

PS: I do read the PRs, but most of them have nothing to nitpick about 😅

@kitbellew
Copy link
Collaborator Author

PS: I do read the PRs, but most of them have nothing to nitpick about 😅

i know that, and i really appreciate it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants